From 1d1bbdda831fefaaf524404c636fa521a77760e2 Mon Sep 17 00:00:00 2001
From: emo <esimeonov@gmail.com>
Date: Wed, 6 Mar 2024 01:23:55 +0100
Subject: [PATCH 1/8] Renames playbook

---
 .../{launch_linux_container.yml => image_published_locally.yml} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename playbooks/{launch_linux_container.yml => image_published_locally.yml} (69%)

diff --git a/playbooks/launch_linux_container.yml b/playbooks/image_published_locally.yml
similarity index 69%
rename from playbooks/launch_linux_container.yml
rename to playbooks/image_published_locally.yml
index 7f590e2..43abcc5 100644
--- a/playbooks/launch_linux_container.yml
+++ b/playbooks/image_published_locally.yml
@@ -1,5 +1,5 @@
 ---
-- name: launch linux container
+- name: Create and publish Linux container image to a local image server
   hosts: localhost
   gather_facts: false
   tasks:
-- 
2.39.5


From c8878ad28b61e98cad32c4ce6499fe58051d2361 Mon Sep 17 00:00:00 2001
From: emo <esimeonov@gmail.com>
Date: Wed, 6 Mar 2024 01:29:56 +0100
Subject: [PATCH 2/8] Adopts the new name of the playbook

---
 extensions/molecule/default/converge.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/extensions/molecule/default/converge.yml b/extensions/molecule/default/converge.yml
index 5b9fb1b..9599bee 100644
--- a/extensions/molecule/default/converge.yml
+++ b/extensions/molecule/default/converge.yml
@@ -4,7 +4,7 @@
   gather_facts: false
 - name: imports and executes the playbook under test
   ansible.builtin.import_playbook: >-
-    theliberatededge.test_linux_containers.launch_linux_container.yml
+    theliberatededge.test_linux_containers.image_published_locally.yml
   vars:
     lte_debian_version: bookworm
     lte_container_name: '{{ molecule_yml.platforms[0].name }}'
-- 
2.39.5


From 4dcdf45a12f68b3b5fe0ace8b96c98d6f50f61ae Mon Sep 17 00:00:00 2001
From: Emil <emil@theliberatededge.org>
Date: Wed, 6 Mar 2024 01:48:51 +0100
Subject: [PATCH 3/8] Introduces LTE_IMAGE_NAME variable.

---
 README.md                                | 28 ++++++++++++++----------
 Taskfile.yml                             |  4 ++--
 extensions/molecule/default/converge.yml |  2 +-
 extensions/molecule/default/destroy.yml  |  6 ++---
 extensions/molecule/default/molecule.yml |  2 +-
 playbooks/image_published_locally.yml    |  4 +++-
 6 files changed, 26 insertions(+), 20 deletions(-)

diff --git a/README.md b/README.md
index 8d62a98..1636672 100644
--- a/README.md
+++ b/README.md
@@ -33,23 +33,27 @@ ansible-galaxy collection install -U --force \
 ## Run the launch_linux_container playbook
 
 Substitute the missing variable valuess and run the playbook
-for launching Debian Bookworm linux containers.
+for creating and publishing Debian Bookworm linux container images
+to a locally running incus image server.
 
 Variables
-- `lte_container_name` stands for the desired container name that
-will be visible when running `incus ls`.
+- `lte_image_name` stands for the desired Linux container image.
 - `lte_container_root_pwd` is the password that will be set for
-the `root` user in the container named `lte_container_name`.
+the `root` user in the containers created out of the `lte_image_name`
+Linux container image.
 
 ```
 LC_ALL=C.UTF-8 ansible-playbook \
-    theliberatededge.test_linux_containers.launch_linux_container \
-        -e "lte_container_name=<container name> lte_container_root_pwd=<password>"
+    theliberatededge.test_linux_containers.image_published_locally \
+        -e "lte_image_name=<image name> lte_container_root_pwd=<password>"
 ```
 
 Once the playbook finishes execution, you should be able to
-connect to the newly launched container as user `root` via
-ssh.
+launch new containers refering to the newly published image name.
+
+```
+incus launch <image_name> <container_name>
+```
 
 ## Include playbook or role from the collection
 
@@ -62,15 +66,15 @@ assign the missing values to the variables first.
 
 ```
 ---
-- name: Launch Linux Container
+- name: Create and publish locally container image
   hosts: all
   gather_facts: false
-- name: imports and executes the playbook under test
+- name: Imports and executes the playbook
   ansible.builtin.import_playbook:
-    theliberatededge.test_linux_containers.launch_linux_container.yml
+    theliberatededge.test_linux_containers.image_publlished_locally.yml
   vars:
     lte_debian_version: bookworm
-    lte_container_name: <container name>
+    lte_image_name: <image name>
     lte_container_root_pwd: <password>
 ```
 
diff --git a/Taskfile.yml b/Taskfile.yml
index c4fe596..c7a5f74 100644
--- a/Taskfile.yml
+++ b/Taskfile.yml
@@ -22,9 +22,9 @@ tasks:
     cmds:
       - |
         LC_ALL=C.UTF-8 \
-        LTE_CONTAINER_NAME={{ .LTE_CONTAINER_NAME }} \
+        LTE_IMAGE_NAME={{ .LTE_IMAGE_NAME }} \
         LTE_CONTAINER_ROOT_PWD={{ .LTE_CONTAINER_ROOT_PWD }} \
         molecule test --all
     vars:
-      LTE_CONTAINER_NAME:
+      LTE_IMAGE_NAME:
         sh: cat /dev/urandom | tr -dc 'a-zA-Z0-9' | fold -w 8 | head -n 1
diff --git a/extensions/molecule/default/converge.yml b/extensions/molecule/default/converge.yml
index 9599bee..b894944 100644
--- a/extensions/molecule/default/converge.yml
+++ b/extensions/molecule/default/converge.yml
@@ -7,6 +7,6 @@
     theliberatededge.test_linux_containers.image_published_locally.yml
   vars:
     lte_debian_version: bookworm
-    lte_container_name: '{{ molecule_yml.platforms[0].name }}'
+    lte_image_name: '{{ molecule_yml.platforms[0].name }}'
     lte_container_root_pwd: |-
       '{{ lookup("ansible.builtin.env", "LTE_CONTAINER_ROOT_PWD") }}'
diff --git a/extensions/molecule/default/destroy.yml b/extensions/molecule/default/destroy.yml
index d8439ac..a4d9f85 100644
--- a/extensions/molecule/default/destroy.yml
+++ b/extensions/molecule/default/destroy.yml
@@ -5,14 +5,14 @@
   gather_facts: false
   tasks:
     - name: find current container state
-      ansible.builtin.command: incus ls {{ item.name }}
+      ansible.builtin.command: incus ls "{{ item.name }}-container"
       register: state
       changed_when: false
       with_items: '{{ molecule_yml.platforms }}'
     - name: stop and remove running containers
       ansible.builtin.shell:
         cmd: |
-          incus stop {{ item.name }} && \
-          incus rm {{ item.name }}
+          incus stop "{{ item.name }}-container" && \
+          incus rm "{{ item.name }}-container"
       when: state.results[0].rc == 0 and "RUNNING" in state.results[0].stdout
       with_items: '{{ molecule_yml.platforms }}'
diff --git a/extensions/molecule/default/molecule.yml b/extensions/molecule/default/molecule.yml
index 9a40fa3..8b06138 100644
--- a/extensions/molecule/default/molecule.yml
+++ b/extensions/molecule/default/molecule.yml
@@ -2,7 +2,7 @@
 dependency:
   name: galaxy
 platforms:
-  - name: ${LTE_CONTAINER_NAME}
+  - name: ${LTE_IMAGE_NAME}
 provisioner:
   name: ansible
   playbooks:
diff --git a/playbooks/image_published_locally.yml b/playbooks/image_published_locally.yml
index 43abcc5..2b84d49 100644
--- a/playbooks/image_published_locally.yml
+++ b/playbooks/image_published_locally.yml
@@ -2,7 +2,9 @@
 - name: Create and publish Linux container image to a local image server
   hosts: localhost
   gather_facts: false
+  vars:
+    - lte_container_name: '{{ lte_image_name }}-container'
   tasks:
-    - name: Create a test container image template
+    - name: Create a test container
       ansible.builtin.import_role:
         name: linux_container
-- 
2.39.5


From 8daf94c1be2f87e67b7ed9be97723a29c23c7462 Mon Sep 17 00:00:00 2001
From: Emil <emil@theliberatededge.org>
Date: Wed, 6 Mar 2024 02:08:32 +0100
Subject: [PATCH 4/8] Adds container state to container role.

---
 roles/linux_container/defaults/main.yml   |  1 +
 roles/linux_container/tasks/container.yml | 15 ++++++++++++++-
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/roles/linux_container/defaults/main.yml b/roles/linux_container/defaults/main.yml
index 2df44ba..85a16e8 100644
--- a/roles/linux_container/defaults/main.yml
+++ b/roles/linux_container/defaults/main.yml
@@ -1,2 +1,3 @@
 ---
 lte_debian_version: bookworm
+lte_container_state: present
diff --git a/roles/linux_container/tasks/container.yml b/roles/linux_container/tasks/container.yml
index 8e58a1f..9a90ea5 100644
--- a/roles/linux_container/tasks/container.yml
+++ b/roles/linux_container/tasks/container.yml
@@ -3,17 +3,30 @@
   ansible.builtin.command: incus ls {{ lte_container_name }}
   register: container_state
   changed_when: false
+- name: stop and remove running container
+  ansible.builtin.shell:
+    cmd: |
+      incus stop {{ lte_container_name }} && \
+      incus rm {{ lte_container_name }}
+  when: >
+    lte_container_state == "absent" and
+    state.results[0].rc == 0 and
+    "RUNNING" in state.results[0].stdout
 - name: launch debian bookworm linux container
   ansible.builtin.shell:
     cmd: |
       incus launch \
         images:debian/{{ lte_debian_version }}/cloud \
         {{ lte_container_name }}
-  when: (container_state.rc == 1) or ("RUNNING" not in container_state.stdout)
+  when: >
+    lte_container_state == "present" and
+    container_state.rc == 1 or
+    "RUNNING" not in container_state.stdout
 - name: update apt cache and upgrade system packages
   ansible.builtin.shell:
     cmd: |-
       incus exec {{ lte_container_name }} -- \
         bash -c \
           '/usr/bin/apt update && /usr/bin/apt upgrade -y'
+  when: lte_container_state == "present" 
   changed_when: false
-- 
2.39.5


From e5290372695d60c8f0f32744ca012f7d9f6361ad Mon Sep 17 00:00:00 2001
From: Emil <emil@theliberatededge.org>
Date: Wed, 6 Mar 2024 02:35:07 +0100
Subject: [PATCH 5/8] Adds basic container state managementto linux_container
 role

---
 extensions/molecule/default/destroy.yml   | 20 ++++++++------------
 roles/linux_container/tasks/container.yml | 15 ++++++++-------
 roles/linux_container/tasks/main.yml      |  2 ++
 3 files changed, 18 insertions(+), 19 deletions(-)

diff --git a/extensions/molecule/default/destroy.yml b/extensions/molecule/default/destroy.yml
index a4d9f85..95338c7 100644
--- a/extensions/molecule/default/destroy.yml
+++ b/extensions/molecule/default/destroy.yml
@@ -1,18 +1,14 @@
 ---
-- name: Create
+- name: Destroy testing resources
   hosts: localhost
   connection: local
   gather_facts: false
   tasks:
-    - name: find current container state
-      ansible.builtin.command: incus ls "{{ item.name }}-container"
-      register: state
-      changed_when: false
-      with_items: '{{ molecule_yml.platforms }}'
-    - name: stop and remove running containers
-      ansible.builtin.shell:
-        cmd: |
-          incus stop "{{ item.name }}-container" && \
-          incus rm "{{ item.name }}-container"
-      when: state.results[0].rc == 0 and "RUNNING" in state.results[0].stdout
+    - name: Stop and remove the test container
+      ansible.builtin.include_role:
+        name: >-
+          theliberatededge.test_linux_containers.linux_container
+      vars:
+        lte_container_state: absent
+        lte_container_name: '{{ item.name }}-container'
       with_items: '{{ molecule_yml.platforms }}'
diff --git a/roles/linux_container/tasks/container.yml b/roles/linux_container/tasks/container.yml
index 9a90ea5..1cd794c 100644
--- a/roles/linux_container/tasks/container.yml
+++ b/roles/linux_container/tasks/container.yml
@@ -9,9 +9,10 @@
       incus stop {{ lte_container_name }} && \
       incus rm {{ lte_container_name }}
   when: >
-    lte_container_state == "absent" and
-    state.results[0].rc == 0 and
-    "RUNNING" in state.results[0].stdout
+    lte_container_state == 'absent' and
+    'results' in container_state and
+    container_state.results[0].rc == 0 and
+    'RUNNING' in container_state.results[0].stdout
 - name: launch debian bookworm linux container
   ansible.builtin.shell:
     cmd: |
@@ -19,14 +20,14 @@
         images:debian/{{ lte_debian_version }}/cloud \
         {{ lte_container_name }}
   when: >
-    lte_container_state == "present" and
-    container_state.rc == 1 or
-    "RUNNING" not in container_state.stdout
+    lte_container_state == 'present' and
+    (container_state.rc == 1) or
+    ("RUNNING" not in container_state.stdout)
 - name: update apt cache and upgrade system packages
   ansible.builtin.shell:
     cmd: |-
       incus exec {{ lte_container_name }} -- \
         bash -c \
           '/usr/bin/apt update && /usr/bin/apt upgrade -y'
-  when: lte_container_state == "present" 
+  when: lte_container_state == 'present'
   changed_when: false
diff --git a/roles/linux_container/tasks/main.yml b/roles/linux_container/tasks/main.yml
index 845cbc5..1a49eef 100644
--- a/roles/linux_container/tasks/main.yml
+++ b/roles/linux_container/tasks/main.yml
@@ -1,4 +1,6 @@
 ---
 - ansible.builtin.include_tasks: container.yml
 - ansible.builtin.include_tasks: ume.yml
+  when: lte_container_state == "present"
 - ansible.builtin.include_tasks: openssh-server.yml
+  when: lte_container_state == "present"
-- 
2.39.5


From 2b1923e40a8926ddc47a8d4cd3c38d034968fc62 Mon Sep 17 00:00:00 2001
From: Emil <emil@theliberatededge.org>
Date: Wed, 6 Mar 2024 02:39:16 +0100
Subject: [PATCH 6/8] Fixes issues with consistency

---
 roles/linux_container/tasks/container.yml | 4 ++--
 roles/linux_container/tasks/main.yml      | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/roles/linux_container/tasks/container.yml b/roles/linux_container/tasks/container.yml
index 1cd794c..0544466 100644
--- a/roles/linux_container/tasks/container.yml
+++ b/roles/linux_container/tasks/container.yml
@@ -21,8 +21,8 @@
         {{ lte_container_name }}
   when: >
     lte_container_state == 'present' and
-    (container_state.rc == 1) or
-    ("RUNNING" not in container_state.stdout)
+    container_state.rc == 1 or
+    'RUNNING' not in container_state.stdout
 - name: update apt cache and upgrade system packages
   ansible.builtin.shell:
     cmd: |-
diff --git a/roles/linux_container/tasks/main.yml b/roles/linux_container/tasks/main.yml
index 1a49eef..65ecffb 100644
--- a/roles/linux_container/tasks/main.yml
+++ b/roles/linux_container/tasks/main.yml
@@ -1,6 +1,6 @@
 ---
 - ansible.builtin.include_tasks: container.yml
 - ansible.builtin.include_tasks: ume.yml
-  when: lte_container_state == "present"
+  when: lte_container_state == 'present'
 - ansible.builtin.include_tasks: openssh-server.yml
-  when: lte_container_state == "present"
+  when: lte_container_state == 'present'
-- 
2.39.5


From da93d7f4b44cb9b1ea756680a26448ff67c890fb Mon Sep 17 00:00:00 2001
From: Emil <emil@theliberatededge.org>
Date: Thu, 7 Mar 2024 02:36:34 +0100
Subject: [PATCH 7/8] Adds image creation and publishing

---
 README.md                                 |  2 +
 extensions/molecule/default/verify.yml    |  6 ++-
 playbooks/image_published_locally.yml     | 17 +++++++-
 roles/image/README.md                     | 38 +++++++++++++++++
 roles/image/defaults/main.yml             |  2 +
 roles/image/handlers/main.yml             |  2 +
 roles/image/meta/main.yml                 | 50 +++++++++++++++++++++++
 roles/image/tasks/image.yml               | 22 ++++++++++
 roles/image/tasks/main.yml                |  2 +
 roles/image/tests/inventory               |  2 +
 roles/image/tests/test.yml                |  4 ++
 roles/image/vars/main.yml                 |  2 +
 roles/linux_container/tasks/container.yml | 16 +++++---
 13 files changed, 156 insertions(+), 9 deletions(-)
 create mode 100644 roles/image/README.md
 create mode 100644 roles/image/defaults/main.yml
 create mode 100644 roles/image/handlers/main.yml
 create mode 100644 roles/image/meta/main.yml
 create mode 100644 roles/image/tasks/image.yml
 create mode 100644 roles/image/tasks/main.yml
 create mode 100644 roles/image/tests/inventory
 create mode 100644 roles/image/tests/test.yml
 create mode 100644 roles/image/vars/main.yml

diff --git a/README.md b/README.md
index 1636672..5731d96 100644
--- a/README.md
+++ b/README.md
@@ -19,6 +19,7 @@ effectively be used as a container hypervisor.
 3. Your user has been granted permissions to manage Linux containers.
 4. Python 3 has been set up correctly on the machine.
 5. [Ansible](https://pypi.org/project/ansible/) has been installed.
+6. [pigz](https://zlib.net/pigz/) has been installed.
 
 # Install the Ansible collection theliberatededge.test_linux_containers
 
@@ -137,6 +138,7 @@ a container hypervisor.
 6. [git](https://git-scm.com/) has been installed on the machine.
 7. [Task](https://github.com/go-task/task) has been installed and has been
 available in the `$PATH` environment variable for the current user.
+8. [pigz](https://zlib.net/pigz/) has been installed.
 
 ### Initialize collection project locally
 
diff --git a/extensions/molecule/default/verify.yml b/extensions/molecule/default/verify.yml
index 42d5d19..bda6cb3 100644
--- a/extensions/molecule/default/verify.yml
+++ b/extensions/molecule/default/verify.yml
@@ -3,8 +3,12 @@
   hosts: localhost
   gather_facts: false
   tasks:
+    - name: Launch container based on the newly published image
+      ansible.builtin.command: |
+        incus launch {{ item.name }} "{{ item.name }}-test-cntr"
+      with_items: '{{ molecule_yml.platforms }}'
     - name: find current container state
-      ansible.builtin.command: incus ls {{ item.name }}
+      ansible.builtin.command: incus ls "{{ item.name }}-test-cntr"
       register: state
       with_items: '{{ molecule_yml.platforms }}'
     - name: verify launched container is running
diff --git a/playbooks/image_published_locally.yml b/playbooks/image_published_locally.yml
index 2b84d49..bbbbc64 100644
--- a/playbooks/image_published_locally.yml
+++ b/playbooks/image_published_locally.yml
@@ -1,10 +1,23 @@
 ---
-- name: Create and publish Linux container image to a local image server
+- name: Create and publish a Linux container image to a local image server
   hosts: localhost
   gather_facts: false
   vars:
     - lte_container_name: '{{ lte_image_name }}-container'
   tasks:
-    - name: Create a test container
+    - name: Launch a test container
       ansible.builtin.import_role:
         name: linux_container
+    - name: Stop the newly launched test container
+      ansible.builtin.import_role:
+        name: linux_container
+      vars:
+        lte_container_state: stopped
+    - name: Publish container image to local image server
+      ansible.builtin.import_role:
+        name: image
+    - name: Remove intermitent image container
+      ansible.builtin.import_role:
+        name: linux_container
+      vars:
+        - lte_container_state: absent
diff --git a/roles/image/README.md b/roles/image/README.md
new file mode 100644
index 0000000..225dd44
--- /dev/null
+++ b/roles/image/README.md
@@ -0,0 +1,38 @@
+Role Name
+=========
+
+A brief description of the role goes here.
+
+Requirements
+------------
+
+Any pre-requisites that may not be covered by Ansible itself or the role should be mentioned here. For instance, if the role uses the EC2 module, it may be a good idea to mention in this section that the boto package is required.
+
+Role Variables
+--------------
+
+A description of the settable variables for this role should go here, including any variables that are in defaults/main.yml, vars/main.yml, and any variables that can/should be set via parameters to the role. Any variables that are read from other roles and/or the global scope (ie. hostvars, group vars, etc.) should be mentioned here as well.
+
+Dependencies
+------------
+
+A list of other roles hosted on Galaxy should go here, plus any details in regards to parameters that may need to be set for other roles, or variables that are used from other roles.
+
+Example Playbook
+----------------
+
+Including an example of how to use your role (for instance, with variables passed in as parameters) is always nice for users too:
+
+    - hosts: servers
+      roles:
+         - { role: username.rolename, x: 42 }
+
+License
+-------
+
+BSD
+
+Author Information
+------------------
+
+An optional section for the role authors to include contact information, or a website (HTML is not allowed).
diff --git a/roles/image/defaults/main.yml b/roles/image/defaults/main.yml
new file mode 100644
index 0000000..ff4e5fb
--- /dev/null
+++ b/roles/image/defaults/main.yml
@@ -0,0 +1,2 @@
+---
+lte_image_state: present
diff --git a/roles/image/handlers/main.yml b/roles/image/handlers/main.yml
new file mode 100644
index 0000000..91da2a7
--- /dev/null
+++ b/roles/image/handlers/main.yml
@@ -0,0 +1,2 @@
+---
+...
diff --git a/roles/image/meta/main.yml b/roles/image/meta/main.yml
new file mode 100644
index 0000000..5d7099b
--- /dev/null
+++ b/roles/image/meta/main.yml
@@ -0,0 +1,50 @@
+---
+galaxy_info:
+  author: your name
+  description: your role description
+  company: your company (optional)
+
+  # If the issue tracker for your role is not on github, uncomment the
+  # next line and provide a value
+  # issue_tracker_url: http://example.com/issue/tracker
+
+  # Choose a valid license ID from https://spdx.org - some suggested licenses:
+  # - BSD-3-Clause (default)
+  # - MIT
+  # - GPL-2.0-or-later
+  # - GPL-3.0-only
+  # - Apache-2.0
+  # - CC-BY-4.0
+  license: license (GPL-2.0-or-later, MIT, etc)
+  min_ansible_version: 2.1
+
+  # If this a Container Enabled role, provide the minimum Ansible Container version.
+  # min_ansible_container_version:
+
+  #
+  # Provide a list of supported platforms, and for each platform a list of versions.
+  # If you don't wish to enumerate all versions for a particular platform, use 'all'.
+  # To view available platforms and versions (or releases), visit:
+  # https://galaxy.ansible.com/api/v1/platforms/
+  #
+  # platforms:
+  # - name: Fedora
+  #   versions:
+  #   - all
+  #   - 25
+  # - name: SomePlatform
+  #   versions:
+  #   - all
+  #   - 1.0
+  #   - 7
+  #   - 99.99
+  galaxy_tags: []
+    # List tags for your role here, one per line. A tag is a keyword that describes
+    # and categorizes the role. Users find roles by searching for tags. Be sure to
+    # remove the '[]' above, if you add tags to this list.
+    #
+    # NOTE: A tag is limited to a single word comprised of alphanumeric characters.
+    #       Maximum 20 tags per role.
+dependencies: []
+  # List your role dependencies here, one per line. Be sure to remove the '[]' above,
+  # if you add dependencies to this list.
diff --git a/roles/image/tasks/image.yml b/roles/image/tasks/image.yml
new file mode 100644
index 0000000..8115997
--- /dev/null
+++ b/roles/image/tasks/image.yml
@@ -0,0 +1,22 @@
+---
+- name: Find container image by name
+  ansible.builtin.command: incus image ls {{ lte_image_name }}
+  register: image_state
+  changed_when: false
+- name: Remove an existing container image
+  ansible.builtin.shell:
+    cmd: incus image rm {{ lte_image_name }}
+  when: >
+    lte_image_state == 'absent' and
+    'results' in image_state and
+    image_state.results[0].rc == 0 and
+    lte_image_name in image_state.results[0].stdout
+- name: Create and publish container image to local image server
+  ansible.builtin.shell:
+    cmd: |
+      incus publish --force --alias {{ lte_image_name }} \
+          --compression pigz \
+              {{ lte_container_name }}
+  when: >-
+    lte_image_state == 'present' and
+    lte_image_name not in image_state.stdout
diff --git a/roles/image/tasks/main.yml b/roles/image/tasks/main.yml
new file mode 100644
index 0000000..1cd8aec
--- /dev/null
+++ b/roles/image/tasks/main.yml
@@ -0,0 +1,2 @@
+---
+- ansible.builtin.include_tasks: image.yml
diff --git a/roles/image/tests/inventory b/roles/image/tests/inventory
new file mode 100644
index 0000000..878877b
--- /dev/null
+++ b/roles/image/tests/inventory
@@ -0,0 +1,2 @@
+localhost
+
diff --git a/roles/image/tests/test.yml b/roles/image/tests/test.yml
new file mode 100644
index 0000000..4afc78f
--- /dev/null
+++ b/roles/image/tests/test.yml
@@ -0,0 +1,4 @@
+---
+- hosts: localhost
+  remote_user: root
+  roles: [image]
diff --git a/roles/image/vars/main.yml b/roles/image/vars/main.yml
new file mode 100644
index 0000000..91da2a7
--- /dev/null
+++ b/roles/image/vars/main.yml
@@ -0,0 +1,2 @@
+---
+...
diff --git a/roles/linux_container/tasks/container.yml b/roles/linux_container/tasks/container.yml
index 0544466..6e170cd 100644
--- a/roles/linux_container/tasks/container.yml
+++ b/roles/linux_container/tasks/container.yml
@@ -3,11 +3,15 @@
   ansible.builtin.command: incus ls {{ lte_container_name }}
   register: container_state
   changed_when: false
-- name: stop and remove running container
-  ansible.builtin.shell:
-    cmd: |
-      incus stop {{ lte_container_name }} && \
-      incus rm {{ lte_container_name }}
+- name: Stop running container
+  ansible.builtin.command: incus stop {{ lte_container_name }}
+  when: >
+    lte_container_state in ['absent', 'stopped'] and
+    'results' in container_state and
+    container_state.results[0].rc == 0 and
+    'RUNNING' in container_state.results[0].stdout
+- name: Remove stopped container
+  ansible.builtin.command: incus rm {{ lte_container_name }}
   when: >
     lte_container_state == 'absent' and
     'results' in container_state and
@@ -25,7 +29,7 @@
     'RUNNING' not in container_state.stdout
 - name: update apt cache and upgrade system packages
   ansible.builtin.shell:
-    cmd: |-
+    cmd: |
       incus exec {{ lte_container_name }} -- \
         bash -c \
           '/usr/bin/apt update && /usr/bin/apt upgrade -y'
-- 
2.39.5


From 8202c42cf72307fb86bc307c81c26f1bce364e04 Mon Sep 17 00:00:00 2001
From: Emil <emil@theliberatededge.org>
Date: Thu, 7 Mar 2024 02:39:40 +0100
Subject: [PATCH 8/8] Brings consistency with quotes

---
 extensions/molecule/default/verify.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/extensions/molecule/default/verify.yml b/extensions/molecule/default/verify.yml
index bda6cb3..2a3a7e6 100644
--- a/extensions/molecule/default/verify.yml
+++ b/extensions/molecule/default/verify.yml
@@ -5,15 +5,15 @@
   tasks:
     - name: Launch container based on the newly published image
       ansible.builtin.command: |
-        incus launch {{ item.name }} "{{ item.name }}-test-cntr"
+        incus launch {{ item.name }} {{ item.name }}-test-cntr
       with_items: '{{ molecule_yml.platforms }}'
     - name: find current container state
-      ansible.builtin.command: incus ls "{{ item.name }}-test-cntr"
+      ansible.builtin.command: incus ls '{{ item.name }}-test-cntr'
       register: state
       with_items: '{{ molecule_yml.platforms }}'
     - name: verify launched container is running
       ansible.builtin.assert:
-        that: state.results[0].rc == 0 and "RUNNING" in state.results[0].stdout
+        that: state.results[0].rc == 0 and 'RUNNING' in state.results[0].stdout
     - name: find container ip address
       ansible.builtin.command: incus ls -c=4 -f=compact {{ item.name }}
       register: ipv4_raw
-- 
2.39.5